[java] 3 rules reporting a comment twice for same line

[dinesh150]

Affects PMD Version: 6.37.0
Description: Three rules from java reporting a comment twice for same line

DoNotTerminateVM, ImplicitSwitchFallThrough and ComparisonWithNaN

These three rules from java produces report twice for same line.

Code Sample demonstrating the issue:

// Code is sample for ComparisonWithNaN rule.
 public class Sample{
     public void doSomething(){
        double test = 0;
	boolean rule = (test == Double.NaN);
    }
}

Steps to reproduce:
Use the shared code and shared rule name from CLI.

Running PMD through: [CLI]

[adangel]

Can you share your ruleset?

All three rules have been renamed lately:

• ComparisonWithNaN was previously called BadComparison
• ImplicitSwitchFallThrough was previously called MissingBreakInSwitch
• DoNotTerminateVM was previously called DoNotCallSystemExit

The old rule names are still available, but deprecated:

pmd/pmd-java/src/main/resources/category/java/errorprone.xml

Line 641 in efaf34d

<rule name="BadComparison" ref="ComparisonWithNaN" deprecated="true" />

If you use the complete errorprone category, the old (deprecated) rules should be ignored. You should see duplicated reports only if you explicitly enable e.g. BadComparison and ComparisonWithNaN (which are essentially the same rule).

[jsotuyod]

Marking this as stale after 3 years with no response from the reporter nor a way to reproduce it.