[apex] added fix to not tag single block for two error statements

[arunnc84]

Added check to see if a violation of type EmptyIfStmt or EmptyWhileStmt or EmptyCatchBlock is already present not to add EmptyStatementBlock. Also handled the other scenario, if EmptyStatementBlock is already part of violation remove the violation and add the new violation of type EmptyIfStmt or EmptyWhileStmt or EmptyCatchBlock to the list.

Related issues

#3164

• Fixes #

Ready?

Yes, wrote unit test and all unit tests passed also build and successfully tested in local.

[adangel]

Thanks for your pull request.
However, this is not the solution we want to have for the given problem.
Your solution now hides the root cause, that we have two rules that do the same thing. It furthermore makes the pmd-core module aware, that there some specific rules that need to be filtered out (we have now a cyclic dependency: pmd-apex depends on pmd-core, pmd-core depends on pmd-apex).

What we should do instead is the following (as outlined in the comment on #3164):

1. Create a new rule combines all the Empty* rules that are already existing.
2. Deprecate all the Empty* rules in favor of the new rule
3. Use the new rule in quickstart.xml instead of the now deprecated rules
4. In PMD7 delete all the deprecated Empty* rules

[oowekyala]

As explained by @adangel in #3641 (review), we cannot merge this fix. Refer to #3778 for details about the preferred fix.