Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[java] Improve isOverridden in ASTMethodDeclaration #3749

Closed
oowekyala opened this issue Jan 26, 2022 · 1 comment
Closed

[java] Improve isOverridden in ASTMethodDeclaration #3749

oowekyala opened this issue Jan 26, 2022 · 1 comment
Assignees
@oowekyala
Labels
in:ast About the AST structure or API, the parsing step
Projects
PMD 7
Milestone
7.0.0

Comments

@oowekyala
Copy link
Member

AFAICT, there are FPs due to overridden methods that don't have an @Override annotation. We're anyway using ASTMethodDeclaration::isOverridden, which I'd like to improve to do the same thing as MissingOverride in a resolution pass after parsing. This will suppress FPs in more rules, and we don't need to fix it in this PR

Originally posted by @oowekyala in #3731 (review)
@oowekyala oowekyala added this to the 7.0.0 milestone Jan 26, 2022
@oowekyala oowekyala self-assigned this Jan 26, 2022
@oowekyala oowekyala added this to To do in PMD 7 Jan 27, 2022
@oowekyala oowekyala mentioned this issue Jan 30, 2022
Merged
4 tasks
@oowekyala oowekyala mentioned this issue Apr 7, 2022
Closed
55 tasks
@oowekyala
Copy link
Member Author

Closing as this doesn't need backporting. IsOverridden does not exist on master.

PMD 7 automation moved this from To do to Done Jun 25, 2022
@adangel adangel added the in:ast About the AST structure or API, the parsing step label Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oowekyala oowekyala

Labels
in:ast About the AST structure or API, the parsing step
Projects
No open projects
PMD 7
  
Done
Milestone
7.0.0
Development

No branches or pull requests
2 participants
@adangel @oowekyala