Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[java] Make symbol table support instanceof pattern bindings #3750

Closed
oowekyala opened this issue Jan 27, 2022 · 1 comment · Fixed by #3755
Closed

[java] Make symbol table support instanceof pattern bindings #3750

oowekyala opened this issue Jan 27, 2022 · 1 comment · Fixed by #3755
Labels
an:enhancement An improvement on existing features / rules in:symbol-table Affects the symbol table code
Projects
PMD 7
Milestone
7.0.0

Comments

@oowekyala
Copy link
Member

Pattern matching constructs like if (a instanceof Type b) are flow-sensitive, which makes it a bit harder to implement their scoping rules. This should be handled by symbol tables. I have a very old branch with an implementation, will update it.

This issue is split off from #2701
@oowekyala oowekyala added the an:enhancement An improvement on existing features / rules label Jan 27, 2022
@oowekyala oowekyala added this to the 7.0.0 milestone Jan 27, 2022
@oowekyala oowekyala mentioned this issue Jan 27, 2022
Closed
@oowekyala oowekyala added this to In progress in PMD 7 Jan 27, 2022
@oowekyala oowekyala added the in:symbol-table Affects the symbol table code label Jan 27, 2022
@oowekyala oowekyala mentioned this issue Jan 28, 2022
Merged
5 tasks
@oowekyala oowekyala linked a pull request Feb 7, 2022 that will close this issue
[java] Implement pattern binding scoping #3755
Merged
5 tasks
@oowekyala oowekyala moved this from In progress to Done in PMD 7 Mar 8, 2022
@oowekyala oowekyala mentioned this issue Apr 7, 2022
Closed
55 tasks
@adangel
Copy link
Member

adangel commented Jan 13, 2023

This is done via #3755 for PMD 7.

@adangel adangel closed this as completed Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
an:enhancement An improvement on existing features / rules in:symbol-table Affects the symbol table code
Projects
No open projects
PMD 7
  
Done
Milestone
7.0.0
Development

Successfully merging a pull request may close this issue.

[java] Implement pattern binding scoping oowekyala/pmd
2 participants
@adangel @oowekyala