Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Internalize CPDCommandLineInterface #3979

Merged
merged 2 commits into from May 28, 2022
Merged

[core] Internalize CPDCommandLineInterface #3979

merged 2 commits into from May 28, 2022

Conversation

adangel
Copy link
Member

@adangel adangel commented May 26, 2022

Describe the PR

  • Internalized the compelte CPDCommandLineInterface
  • Especially the system props NO_EXIT_AFTER_RUN and STATUS_CODE_PROPERTY are deprecated
  • Refactor the unit tests a bit to not depend on these system props anymore.
  • Introduced enum CPD.StatusCode similar to PMD.StatusCode.

Related issues

Ready?

  • Added unit tests for fixed bug/feature
  • Passing all unit tests
  • Complete build ./mvnw clean verify passes (checked automatically by github actions)
  • Added (in-code) documentation (if needed)

@adangel adangel added this to the 6.46.0 milestone May 26, 2022
@adangel adangel added the is:deprecation The main focus is deprecating public APIs or rules, eg to make them internal, or removing them label May 26, 2022
@pmd-test
Copy link

pmd-test commented May 26, 2022 •
edited

1 Message
📖 Compared to master:
This changeset changes 0 violations,
introduces 0 new violations, 0 new errors and 0 new configuration errors,
removes 0 violations, 0 errors and 0 configuration errors.
Full report
✅ Compared to master:
This changeset changes 0 violations,
introduces 0 new violations, 0 new errors and 0 new configuration errors,
removes 0 violations, 0 errors and 0 configuration errors.
Full report

Generated by 🚫 Danger

@adangel adangel merged commit ede4c6d into pmd:master May 28, 2022
@adangel adangel deleted the deprecate-cpd-system-props branch May 28, 2022 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
is:deprecation The main focus is deprecating public APIs or rules, eg to make them internal, or removing them
Projects
None yet
Milestone
6.46.0
Development

Successfully merging this pull request may close these issues.

[core] Deprecate system properties of CPDCommandLineInterface
2 participants
@adangel @pmd-test