Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[java] Use type resolution for UseArrayListInsteadOfVector #4156

Merged
merged 2 commits into from Oct 28, 2022
Merged

[java] Use type resolution for UseArrayListInsteadOfVector #4156

merged 2 commits into from Oct 28, 2022

Conversation

adangel
Copy link
Member

@adangel adangel commented Oct 14, 2022

Describe the PR

Just uses type resolution to detect java.util.Vector

Related issues

Ready?

  • Added unit tests for fixed bug/feature
  • Passing all unit tests
  • Complete build ./mvnw clean verify passes (checked automatically by github actions)
  • Added (in-code) documentation (if needed)

@adangel adangel added this to the 6.51.0 milestone Oct 14, 2022
@pmd-test
Copy link

pmd-test commented Oct 14, 2022 •
edited

1 Message
📖 Compared to master:
This changeset changes 0 violations,
introduces 25 new violations, 0 new errors and 0 new configuration errors,
removes 0 violations, 2 errors and 7 configuration errors.
Full report
✅ Compared to master:
This changeset changes 0 violations,
introduces 61 new violations, 0 new errors and 0 new configuration errors,
removes 0 violations, 2 errors and 7 configuration errors.
Full report

Generated by 🚫 Danger

@adangel

This comment was marked as resolved.

Sign in to view
@adangel adangel merged commit af013d6 into pmd:master Oct 28, 2022
@adangel adangel deleted the issue-4148-ArrayListVector branch October 28, 2022 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.51.0
Development

Successfully merging this pull request may close these issues.

[java] UseArrayListInsteadOfVector ignores Vector when other classes are imported
2 participants
@adangel @pmd-test