Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[java] New Rule InvalidJavaBean #4203

Merged
merged 13 commits into from Nov 25, 2022
Merged

Conversation

adangel
Copy link
Member

@adangel adangel commented Nov 10, 2022

Describe the PR

Implements the new rule "InvalidJavaBean".

I don't check any event listeners stuff - this could be added in a later version.

The rule has the property packages which define the packages, that should be checked (similar like LoosePackageCoupling).

Related issues

Ready?

  • Added unit tests for fixed bug/feature
  • Passing all unit tests
  • Complete build ./mvnw clean verify passes (checked automatically by github actions)
  • Added (in-code) documentation (if needed)

@adangel adangel added the a:new-rule Proposal to add a new built-in rule label Nov 10, 2022
@adangel adangel added this to the 6.52.0 milestone Nov 10, 2022
@pmd-test
Copy link

pmd-test commented Nov 10, 2022

1 Message
📖 Compared to master:
This changeset changes 0 violations,
introduces 0 new violations, 0 new errors and 0 new configuration errors,
removes 0 violations, 0 errors and 0 configuration errors.
Full report
Compared to master:
This changeset changes 0 violations,
introduces 0 new violations, 0 new errors and 0 new configuration errors,
removes 0 violations, 0 errors and 0 configuration errors.
Full report
Compared to master:
This changeset changes 0 violations,
introduces 31491 new violations, 0 new errors and 0 new configuration errors,
removes 0 violations, 2 errors and 0 configuration errors.
Full report
Compared to master:
This changeset changes 0 violations,
introduces 27261 new violations, 0 new errors and 0 new configuration errors,
removes 0 violations, 2 errors and 0 configuration errors.
Full report

Generated by 🚫 Danger

@adangel adangel marked this pull request as ready for review November 11, 2022 14:25
@adangel adangel merged commit 93587f0 into pmd:master Nov 25, 2022
@adangel adangel deleted the issue-4177-InvalidJavaBean branch November 25, 2022 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:new-rule Proposal to add a new built-in rule
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[java] New Rule InvalidJavaBean
2 participants