Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Remove unnecessary property color and system property pmd.color in TextColorRenderer #4312

Closed
Tracked by #3898
adangel opened this issue Jan 11, 2023 · 0 comments · Fixed by #4798
Closed
Tracked by #3898
Labels
is:feature-removal Remove an unneeded unused feature
Milestone

Comments

@adangel
Copy link
Member

adangel commented Jan 11, 2023

  • context: [core] Update remaining properties to use PropertyFactory #2450
  • from the code: "TODO should the "textcolor" renderer really support "optional" colors? either use text or textcolor... This property is really weird, the standard boolean properties are false unless value is exactly "true", this one is true unless "false" or "0"..."
@adangel adangel added this to the 7.0.0 milestone Jan 11, 2023
@adangel adangel mentioned this issue Jan 11, 2023
6 tasks
@adangel adangel added the is:feature-removal Remove an unneeded unused feature label Jan 13, 2023
@adangel adangel mentioned this issue Jan 23, 2023
55 tasks
@adangel adangel closed this as completed in 524ac69 Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is:feature-removal Remove an unneeded unused feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant