Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Support environment variable CLASSPATH with pmd.bat under Windows #4395

Merged
merged 1 commit into from
Feb 23, 2023

Conversation

adangel
Copy link
Member

@adangel adangel commented Feb 16, 2023

Describe the PR

Fixes the problem found in #4391

The environment CLASSPATH is supported in run.sh for a long time, but this was obviously never added to pmd.bat.

Note: This needs to be ported to PMD 7 as well - there we seem to support CLASSPATH only in the bash script, but not in pmd.bat.

Ready?

  • Added unit tests for fixed bug/feature
  • Passing all unit tests
  • Complete build ./mvnw clean verify passes (checked automatically by github actions)
  • Added (in-code) documentation (if needed)

@adangel adangel added the a:bug PMD crashes or fails to analyse a file. label Feb 16, 2023
@adangel adangel added this to the 6.55.0 milestone Feb 16, 2023
@pmd-test
Copy link

1 Message
📖 No regression tested rules have been changed.

Generated by 🚫 Danger

@adangel adangel merged commit 2db7255 into pmd:master Feb 23, 2023
@adangel adangel deleted the pmd6-support-env-CLASSPATH branch February 23, 2023 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:bug PMD crashes or fails to analyse a file.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants