[java] New rule ConfusingArgumentToVarargsMethod

[oowekyala]

Describe the PR

The new rule ConfusingArgumentToVarargsMethod is in errorprone and cares about the "confusing argument" part. This makes it so that:

• UnnecessaryVarargsArrayCreation is now always trivially fixable
• ConfusingArgumentToVarargsMethod is more general and does not only check for array allocations, but expressions of any form. For instance it catches the case where you call a varargs method with null as the argument, which is also confusing. Note that this rule corresponds to a javac compiler warning (eg https://github.com/pmd/pmd/actions/runs/8764585900/job/24054740589#step:7:2865)

This PR also fixes the violations of both rules in our codebase

Related issues

• improves on [java] New rule UnnecessaryVarargsArrayCreation #4919

Ready?

• Added unit tests for fixed bug/feature
• Passing all unit tests
• Complete build ./mvnw clean verify passes (checked automatically by github actions)
• Added (in-code) documentation (if needed)

[pmd-test]

	1 Message
📖	Compared to master: This changeset changes 113 violations, introduces 14 new violations, 0 new errors and 0 new configuration errors, removes 1 violations, 0 errors and 0 configuration errors. Download full report as build artifact
✅	Compared to master: This changeset changes 0 violations, introduces 0 new violations, 0 new errors and 0 new configuration errors, removes 142863 violations, 13 errors and 7 configuration errors. Download full report as build artifact

Generated by 🚫 Danger

[adangel]

Thanks!

There seems to be a problem with the regression tester being confused, see pmd/pmd-regression-tester#124
I've now disabled that - maybe we see then some regression results.

If that works, I'm going to merge this later today.

Also thanks for cleanup up the existing code base!