Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve the _insert_disks methods by not generating spheres each time #862

Closed
jgostick opened this issue Jul 10, 2023 · 0 comments · Fixed by #870
Closed

improve the _insert_disks methods by not generating spheres each time #862

jgostick opened this issue Jul 10, 2023 · 0 comments · Fixed by #870

Comments

@jgostick
Copy link
Member

When I originally write the various _insert_disks methods, I envisioned inserting things other than disks, so made the code work such that different shapes could be used (in principle, but didn't actually get that far). Since inserting spheres is so common that it's time to give up on the generalization and just hard code it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant