Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flip Vertical and Flip Horizontal to sprites editor #67

Merged
merged 2 commits into from Jan 31, 2022

Conversation

HomineLudens
Copy link
Contributor

A try to add Flip Vertical and Flip Horizontal to sprites editor.

Consider it mostly like a proof of concept as some aspect of the project are still far to be clear to me : )

image

image

@pmgl
Copy link
Owner

pmgl commented Jan 26, 2022

Seems very fine to me, thank you! I think I will move the buttons to the sidebar though (I will add a main tool "Transform" and put these two options there ; they could be joined by a future rotation tool and maybe scaling tool). I am just trying to hit a first milestone on folders, then I will look into this.

@HomineLudens
Copy link
Contributor Author

Adding it to the toolbar was my first option too, but I didn't think about grouping them, and actually is the best thing to do.
By the way, the toolbar class interface seems not so handy to allow adding line and shape drawing.
Maybe I get it wrong but I didn't found a clean way to manage mouse input to start and end the drawing, and at same time provide user feedback like the region tool.
I'll look with interest at your commits when you'll take care of the subject.
The undo management seems also a candidate point where would be nice to simplify the operation before and after a change. But even here I find hard to help and I can mostly provide only my newbie point of view.

@pmgl pmgl merged commit e0207d1 into pmgl:master Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants