Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edison bulb feedback pt. 2 #24

Open
1 task
pmillspaugh opened this issue Nov 6, 2023 · 0 comments
Open
1 task

Edison bulb feedback pt. 2 #24

pmillspaugh opened this issue Nov 6, 2023 · 0 comments
Assignees
@pmillspaugh
Labels
enhancement New feature or request

Comments

@pmillspaugh
Copy link
Owner

pmillspaugh commented Nov 6, 2023 •
edited
Loading

Commenters on HN had some great suggestions. I already addressed enabling drag on mobile and defaulting to dark on the server in #23. Still TODO:

  • Use cookies or move JS localStorage check to <head> to avoid flicker

It also might be worth moving LightSwitch logic into a reducer.
@pmillspaugh pmillspaugh self-assigned this Nov 6, 2023
@pmillspaugh pmillspaugh added the enhancement New feature or request label Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pmillspaugh pmillspaugh

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pmillspaugh