Server library leaks memory and file descriptors

[rhc54]

Seeing some significant memory leaks from malloc in register_client

[rhc54]

@artpol84 Can we get help from you folks on this? It would be good if v2.0 was valgrind clean.

[artpol84]

Yes, it's in our todo list as well. Let's adjust on deadline.

[rhc54]

Here is some input from the Intel folks:

{
   <insert_a_suppression_name_here>
   Memcheck:Leak
   match-leak-kinds: definite
   fun:malloc
   fun:pmix_bfrop_unpack_string
   fun:pmix_bfrop_unpack
   fun:job_data
   fun:pmix_usock_process_msg
   fun:event_base_loop
   fun:progress_engine
   fun:start_thread
   fun:clone
}
{
   <insert_a_suppression_name_here>
   Memcheck:Leak
   match-leak-kinds: definite
   fun:malloc
   fun:strdup
   fun:pmix_value_xfer
   fun:lookup_cbfunc
   fun:wait_lookup_cbfunc
   fun:pmix_usock_process_msg
   fun:event_base_loop
   fun:progress_engine
   fun:start_thread
   fun:clone
}
{
   <insert_a_suppression_name_here>
   Memcheck:Leak
   match-leak-kinds: definite
   fun:malloc
   fun:pmix_argv_append_nosize
   fun:PMIx_Lookup
   fun:mcl_attach
   fun:main
}
{
   <insert_a_suppression_name_here>
   Memcheck:Leak
   match-leak-kinds: definite
   fun:malloc
   fun:pmix_argv_append_nosize
   fun:PMIx_Lookup
   fun:mcl_uri_lookup_with_pmix
   fun:mcl_attach
   fun:main
}
{
   <insert_a_suppression_name_here>
   Memcheck:Leak
   match-leak-kinds: definite
   fun:malloc
   fun:pmix_argv_append_nosize
   fun:PMIx_Lookup
   fun:mcl_assign_rank_with_pmix
   fun:mcl_startup
   fun:main
}
{
   <insert_a_suppression_name_here>
   Memcheck:Leak
   match-leak-kinds: definite
   fun:malloc
   fun:pmix_hash_store
   fun:pmix_client_process_nspace_blob
   fun:job_data
   fun:pmix_usock_process_msg
   fun:event_base_loop
   fun:progress_engine
   fun:start_thread
   fun:clone
}
{
   <insert_a_suppression_name_here>
   Memcheck:Leak
   match-leak-kinds: definite
   fun:malloc
   fun:pmix_client_process_nspace_blob
   fun:job_data
   fun:pmix_usock_process_msg
   fun:event_base_loop
   fun:progress_engine
   fun:start_thread
   fun:clone
}

[rhc54]

Pretty sure we have this licked now - if not, we can open another issue with specific problems.