Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding CI with Sanitizers #1025

Closed
ax3l opened this issue Jan 6, 2019 · 3 comments · Fixed by #2326
Closed

Adding CI with Sanitizers #1025

ax3l opened this issue Jan 6, 2019 · 3 comments · Fixed by #2326

Comments

@ax3l
Copy link
Contributor

ax3l commented Jan 6, 2019

Hi,

are you planning to add CI to the PMIx repo?

One build could include a build and run with -fsanitize=address in order to avoid introducing memory leaks and violations in updates.

@ax3l ax3l mentioned this issue Jan 6, 2019
5 tasks
@ax3l ax3l changed the title Adding CI Adding CI with Sanitizers Jan 6, 2019
@jjhursey
Copy link
Member

PR #1265 is re-enabling the -fsanitize=address version in the Travis config:

We need community help on plugging the rest of the leaks to get it to pass.

@ax3l
Copy link
Contributor Author

ax3l commented Dec 15, 2019

Little note: my PR is not re-enabling them, but enabling them for the first time ;) I just added these lines already as comments when adding CI in the first place.

Unfortunately, your best chance to get the leaks fixed is to sit down with the original authors of the affected routines. As someone (community) not familiar with the code base, I personally tried several times to get some of them resolved but one needs quite some deep understanding of the business logic to get this patched up initially.

@jjhursey jjhursey added this to the Future milestone Mar 25, 2021
@rhc54
Copy link
Contributor

rhc54 commented Oct 5, 2021

@ax3l I finally got around to doing this in the code base, enabling the "picky" compiler options and adding the sanitize=address option. Even got it all to build and work on my Mac.

However, when trying to get it thru CI, I ran into problems with compilers that support that sanitize option, but appear to require the addition of another library (believe it might be -lasan?). I'm having trouble finding the correct autoconf code to locate that library.

Any suggestions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants