Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy mutable resolved constant data for immutable classes #124

Open
dktapps opened this issue Jun 22, 2023 · 0 comments
Open

Copy mutable resolved constant data for immutable classes #124

dktapps opened this issue Jun 22, 2023 · 0 comments

Comments

@dktapps
Copy link
Member

dktapps commented Jun 22, 2023

Recently, some LB code had a problem with OPcache, because of IS_CONSTANT_AST constants being used in immutable classes. These AST were referencing constants which didn't exist on the target worker. This would have been fine (since the constants would normally be resolved during class compile (I think?), but since the classes were inherited without copying their resolved constant data, these constant references suddenly stopped working on PHP 8.1.

@dktapps dktapps changed the title Copy resolved constant data Copy mutable resolved constant data for immutable classes Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant