Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

question about velocity update order #1

Closed
weixuef opened this issue Nov 15, 2023 · 1 comment
Closed

question about velocity update order #1

weixuef opened this issue Nov 15, 2023 · 1 comment

Comments

@weixuef
Copy link

weixuef commented Nov 15, 2023

Hello, this is a very good project. I have a confusion: before the diffusion term is time discretized (lines 127 to 128 in the program), the velocity has been updated (lines 114, 115, 123, and 124). The diffusion term (lines 127 and 128) uses the updated velocity, whereas I think it should use the velocity before the update. Please help me answer it. Thank you so much!

@pmocz
Copy link
Owner

pmocz commented Nov 16, 2023

Both are valid approaches. I did a simple operator splitting here. I think your suggested approach and mine would both formally be 1st order accurate in time, and you'd need to do something more to get 2nd order accuracy

@pmocz pmocz closed this as completed Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants