Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance Degradation with --enable-valgrind #78

Closed
shintaro-iwasaki opened this issue Nov 5, 2018 · 1 comment
Closed

Performance Degradation with --enable-valgrind #78

shintaro-iwasaki opened this issue Nov 5, 2018 · 1 comment

Comments

@shintaro-iwasaki
Copy link
Collaborator

--enable-valgrind significantly degrades performance of Argobots.
It is caused by serialization of thread creation/destruction.
https://github.com/pmodels/argobots/blob/master/src/mem/valgrind.c

Removing this lock (ABTI_valgrind_lock_acquire and ABTI_valgrind_lock_release) can improve the performance (e.g., by storing valgrind_id in ABTI_thread or the stack descriptor.)
@shintaro-iwasaki
Copy link
Collaborator Author

I believe #114 fixes this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@shintaro-iwasaki