Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Calmar and Sortino ratios #11

Merged
merged 8 commits into from Feb 7, 2017
Merged

Conversation

Anjum48
Copy link
Contributor

@Anjum48 Anjum48 commented May 11, 2016

As per issue #10.

For the Calmar Ratio I used the method discussed here: http://investexcel.net/calmar-ratio/
For the Sortino Ratio I used this method: http://investexcel.net/calculate-the-sortino-ratio-with-excel/

I think I've implemented them correctly, but it might need a skilled eye to sense check it :)

@Anjum48 Anjum48 closed this Aug 1, 2016
@pmorissette
Copy link
Owner

Hey @Anjum48,

Sorry I didn't get back to you - totally lost track. Let me take a look and I will merge your commits in if all is well.

Thanks for your contribution!

Cheers,
Phil

@BlinkyBillToo
Copy link

BlinkyBillToo commented Feb 4, 2017

I just updated to the latest FFN release (0.1.12), but I did not see these ratios included.

Any chance they can be merged in anytime soon?

@sven337
Copy link
Contributor

sven337 commented Feb 4, 2017

I'm interested in the Sortino ratio too. Phil, is this going to be merged?
Thanks!

@Anjum48
Copy link
Contributor Author

Anjum48 commented Feb 4, 2017

Sorry guys - totally forgot about this. I'll submit the PR again and see if it'll merge

@Anjum48 Anjum48 reopened this Feb 4, 2017
@pmorissette
Copy link
Owner

Sorry all - let me get on this asap!

@pmorissette pmorissette merged commit 4925bd3 into pmorissette:master Feb 7, 2017
@pmorissette
Copy link
Owner

Ok I merged it in and just refactored your code a bit afterwards. Now we have calc_calmar_ratio and calc_sortino_ratio as well in core.py.

Thanks again for your contribution and sorry for taking so long to reply.

@satoshi
Copy link

satoshi commented Oct 13, 2019

Hi,

Calmar ratio actually isn't CAGR / MaxDD. What we have in ffn is called MAR:
https://www.rcmalternatives.com/2013/08/mar-and-calmar-ratios-identical-twins-with-opposite-personalities

Unlike MAR, Calmar uses (typically) 36 month periods to evaluate performances. While both are useful risk-adjusted metrics, calling MAR Calmar is a misnomer in my opinion. Any chance Calmar is renamed as MAR ratio?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants