Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to dart-sass? #97

Open
willbuckingham opened this issue Mar 9, 2021 · 2 comments
Open

Update to dart-sass? #97

willbuckingham opened this issue Mar 9, 2021 · 2 comments

Comments

@willbuckingham
Copy link

With the deprecation of LibSass / node-sass https://sass-lang.com/blog/libsass-is-deprecated , do you intend to change the peer dependency to sass?

Both have the same JS Api. https://sass-lang.com/documentation/js-api

And they seem to work fine with this importer, however you get a terminal warning about unmet peer dependencies. Honestly not sure if there's a way to make it an either/or peer dependency. OR perhaps a rebrand of this library is coming down the line.

@brandonkramer
Copy link

Yes, would love to see this work with dart-sass without getting the terminal warning

@rootwork
Copy link

I've been using this with dart-sass regularly and it seems to be working fine, apart from the warning. Worth splitting into a node-sass release and a dart-sass release?

Or, alternatively, what about not having any peer dependencies defined, and then include a check somewhere to only warn if the user has no version of Sass installed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants