Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SimpleZip does not work with all eligible IO::Compress::Zip parameters #17

Open
dv-petrov opened this issue Oct 22, 2020 · 1 comment
Open
Assignees
Labels
enhancement New feature or request

Comments

@dv-petrov
Copy link

The package uses its own %PARAMS, and throws exception when parameter is not listed where. But Efs param, for example, does not listed.
This can be avoided in calling program by something like $Archive::Zip::SimpleZip::PARAMS{efs} = [IO::Compress::Base::Common::Parse_boolean, 0];, but this solution smells.

@pmqs pmqs self-assigned this Oct 22, 2020
@pmqs
Copy link
Owner

pmqs commented Oct 23, 2020

SimpleZip isn't designed to automatically work with all the corresponding parameters from IO::Compress::Zip. I only support a sub-set.

That said, the efs parameter is one I do want to support. Just didn't get round to it.

Is this a feature you need?

@pmqs pmqs added the enhancement New feature or request label Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants