Implement nqp::splice.

pmurias · Feb 5, 2015 · 83b4da9 · 83b4da9
1 parent 9d92aa8
commit 83b4da9
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/src/vm/js/QAST/Compiler.nqp b/src/vm/js/QAST/Compiler.nqp
@@ -628,6 +628,7 @@ class QAST::OperationsJS {
     add_simple_op('pop', $T_OBJ, [$T_OBJ], sub ($array) {"$array.pop()"}, :sideffects);
     add_simple_op('push', $T_OBJ, [$T_OBJ, $T_OBJ], sub ($array, $elem) {"$array.push($elem)"}, :sideffects);
     add_simple_op('unshift', $T_OBJ, [$T_OBJ, $T_OBJ], sub ($array, $elem) {"$array.unshift($elem)"}, :sideffects);
+    add_simple_op('splice', $T_OBJ, [$T_OBJ, $T_OBJ, $T_INT, $T_INT], :sideffects);
 
     add_simple_op('iterator', $T_OBJ, [$T_OBJ], :sideffects);
 

diff --git a/src/vm/js/nqp-runtime/core.js b/src/vm/js/nqp-runtime/core.js
@@ -218,3 +218,14 @@ op.curcode = function() {
   var current = arguments.callee.caller;
   return current.codeRef;
 };
+
+
+// TODO benchmark and pick a fast way of doing this
+op.splice = function(target, source, offset, length) {
+  var args = [offset, length];
+  for (var i = 0; i < source.length; i++) {
+    args.push(source[i]);
+  }
+  target.splice.apply(target, args);
+  return target;
+}