Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create swift3.0 branch #14

Closed
lfarah opened this issue Jun 15, 2016 · 7 comments
Closed

Create swift3.0 branch #14

lfarah opened this issue Jun 15, 2016 · 7 comments

Comments

@lfarah
Copy link
Contributor

lfarah commented Jun 15, 2016

Hey @codeido,
I'd love to help PMAlertController to be ported to Swift 3. Can we create a new branch for that?

@pmusolino
Copy link
Owner

Hey @lfarah! Yeah, i think that this is a wonderful idea.
Before creating the branch, you've already used the library with Swift 3?

Let me know ;)
Thanks
-Paolo-

@lfarah
Copy link
Contributor Author

lfarah commented Jun 15, 2016

Yes. I just finished porting the example app. Loooooots of changes!

@pmusolino
Copy link
Owner

Oh @lfarah i read your comments late.
Anyway, i created the new branch and i've updated the library and the example app to swift 3.
https://github.com/Codeido/PMAlertController/tree/swift3

Let me know if you found something that is not ok.
Thank's very much
Paolo

@lfarah
Copy link
Contributor Author

lfarah commented Jun 17, 2016

Awesome! I'll take a look

@pmusolino
Copy link
Owner

pmusolino commented Sep 17, 2016

The master branch actually support swift 2.3. If you need swift 3.0, you have to use this https://github.com/Codeido/PMAlertController/tree/swift3

You can use it via cocoapods:

pod 'PMAlertController', :git => 'https://github.com/Codeido/PMAlertController', :branch => 'swift3'

Soon the branch will be merged.

@lfarah
Copy link
Contributor Author

lfarah commented Sep 17, 2016

I think it would be nice to merge right now since Xcode 8 was launched. It's always good to give instructions for the people who need the Xcode 7 branch

@pmusolino
Copy link
Owner

Hi @lfarah
Yes sure 👍
I merged the swift 3 branch inside the master branch, and the new version is now available on cocoapods under 2.0.0 tag.

Check it out: https://github.com/Codeido/PMAlertController/releases/tag/2.0.0

Let me know if you want to change something inside the readme file or inside the release log.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants