Swift 3 Support is missing ?

[YHSX88]

Hi

I love the library but I don't think it has Swift 3 support as Xcode 8 is telling me that I need to do a lot of changes.

for example:
//MARK: - Customizations
@objc private func setShadowAlertView(){
alertView.layer.masksToBounds = false
alertView.layer.shadowOffset = CGMake(0,0) and should be CGSize(width: 0, height: 0)
alertView.layer.shadowRadius = 8
alertView.layer.shadowOpacity = 0.3
}

What I'm missing ?

[pmusolino]

Hi @YHSX88.
Are you using the correct branch of the library?

The master branch actually support swift 2.3. If you need swift 3.0, you have to use this https://github.com/Codeido/PMAlertController/tree/swift3

You can use it via cocoapods:

pod 'PMAlertController', :git => 'https://github.com/Codeido/PMAlertController', :branch => 'swift3'

[YHSX88]

Hi Codeido
I got this message with the pod you gave me ?

[!] Invalid Podfile file: syntax error, unexpected tLABEL
...lertController', :git => https://github.com/Codeido/PMAlertC...
... ^
/Xcode8_projects/PMtest_SW3/Podfile:5: unknown regexp options - gthb
/Xcode8_projects/PMtest_SW3/Podfile:5: syntax error, unexpected tSTRING_BEG, expecting keyword_do or '{' or '('
....com/Codeido/PMAlertController', :branch => 'swift3'
... ^
/Xcode8_projects/PMtest_SW3/Podfile:5: syntax error, unexpected tIDENTIFIER, expecting end-of-input
...Controller', :branch => 'swift3'
... ^.

[pmusolino]

Ops, try again now, I modified the string of my previous comment.

[YHSX88]

On empty project when I did pod install with the link provided Xcode 8 is giving me still suggestion to change to Swift 3

[pmusolino]

Porting to swift 3 is not yet 100% complete.
I'll do an update on the branch in a few minutes. I will alert you here.

[YHSX88]

Thank you, and you know sorry for this but in the description is saying Support of Swift 2.3 and 3

Thank you in advance.

[pmusolino]

Hi @YHSX88, try now.

Thanks
-Paolo

[YHSX88]

Ok Just did it
and I got the message from xcode to convert to swift 3 but then xcode found no changes to make
but after this I still got 64 errors.

[YHSX88]

And this is the podfile text

platform :ios, '9.0'
use_frameworks!

target 'PM_SW3' do

pod 'PMAlertController', :git => 'https://github.com/Codeido/PMAlertController', :branch => 'swift3'

end

[pmusolino]

Oh, i see that your project need an update to the recommended settings. Do it, and retry.

Make sure that in Build Settings there are these two options

and

[pmusolino]

I think that another reason can be the settings of Cocoapods (i tryed now the library on another project and is working).

Try to insert in your podfile this:

post_install do |installer| installer.pods_project.targets.each do |target| target.build_configurations.each do |config| config.build_settings['SWIFT_VERSION'] = '3.0' end end end

[YHSX88]

It is working with the first suggestion however not sure why but I don't have setting exactly as you
do i.e. SWIFT_VERSION I do have this:

[YHSX88]

Anyway thanks a lot :)

[pmusolino]

Excellent 👍
In the first case it was an error inside the library. In the second case was an error of configuration of the project.

Thanks for your contribution @YHSX88 ;)
-Paolo

[YHSX88]

Aaah just to ask you, for anybody out there when do you plan to move swift 3 on the master branch ?

[pmusolino]

Barring unforeseen circumstances, tomorrow, and i want to integrate this #15 as a new feature.

[YHSX88]

Great :)

[pmusolino]

The new version compatible with Swift 3 is now on master branch and is available on cocoapods.
f73c944

[YHSX88]

Hi thanks for this !

I just tried to install via podfile -> pod 'PMAlertController'
and it is downloading ver 1.1.0:

then I tried to get it from the master and I got it like you said:

source 'https://github.com/CocoaPods/Specs.git'
platform :ios, '9.0'
use_frameworks!

target 'PM_SW3_final' do

pod 'PMAlertController', :git => 'https://github.com/Codeido/PMAlertController', :branch => ‘master’

end

Then it gave me many errors like 64 in count, but I just recompiled and it is working JUST FINE now.

This is for anybody out there.