Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add connection timeout + misc improvements #440

Merged
merged 4 commits into from Dec 19, 2023

Conversation

austin-bowen
Copy link
Contributor

Primary Changes

  • Add optional connection timeout, e.g. gTTS("text", timeout=1.2).
    • timeout defaults to None, so default behavior is unchanged.

Misc Improvements

  • Fix bug in _tokenize() where empty tokens were still allowed through.
  • Replace _len() function with just len(); it is not needed, as Python 2 is no longer supported.
  • Fix typos.

Copy link

codecov bot commented Dec 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (dc4ce71) 98.77% compared to head (e83319a) 98.76%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #440      +/-   ##
==========================================
- Coverage   98.77%   98.76%   -0.01%     
==========================================
  Files          13       13              
  Lines         326      324       -2     
==========================================
- Hits          322      320       -2     
  Misses          4        4              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pndurette
Copy link
Owner

Wow I had a lot of typos!
Thanks a lot for this, and for the cleanup (there's many Py2 recents indeed).

I'll only be able to review more thoroughly after the weekend (earlier perhaps) but very useful addition thank you!

@pndurette pndurette merged commit bcdb79d into pndurette:main Dec 19, 2023
17 checks passed
@pndurette
Copy link
Owner

This has been released! Thanks!

@austin-bowen
Copy link
Contributor Author

Woo! Thanks 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants