Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compare only regex #230

Closed

Conversation

AlexVerschoot
Copy link

Settings
Added options to only compare regexes.
For this, i added settings to enable regex processing in the Engine + a text field where the regex lives.

settings

Use case
In my field of work i often work with cnc machining nc codes, where it will come handy when comparing coordinates like the following.
The default compare :
noregex
With regex : X[0-9].?[0-9] (only compare x-coordinates) :

regex

@pnedev
Copy link
Owner

pnedev commented Mar 17, 2020

Hi @AlexVerschoot ,

That is a very useful addition indeed, thank you for sharing it.

I will not merge it yet because I would like to finally release the first version of the new plugin (ComparePlus) without adding new functionality.
In the future I might use only parts of it because I actually had a different idea that is similar to yours but kind of opposite - to ignore the lines (or parts of lines) that match the regex. I planned it to be part of the "Ignore" options, something like "Advanced Ignore..." that opens new dialog where the user can choose different extended ignore conditions.

Anyway, I appreciate your contribution, thank you once again.

BR

@pnedev pnedev mentioned this pull request May 17, 2020
@pnedev
Copy link
Owner

pnedev commented Jul 17, 2022

Hello @AlexVerschoot ,

I have added Advanced Ignore function to ComparePlus plugin that I'm about to release in a month. It gives the possibility to ignore regex-es.
Thank you once again for the PR 👍

BR

@pnedev pnedev closed this Jul 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants