Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Known Issues / Reminders #68

Closed
Yaron10 opened this issue May 19, 2016 · 17 comments
Closed

Known Issues / Reminders #68

Yaron10 opened this issue May 19, 2016 · 17 comments

Comments

@Yaron10
Copy link

Yaron10 commented May 19, 2016

#66.
#48.


_EDIT: FIXED_

Reminder:
In a RTL interface NPP flips horizontally the toolbar buttons.
The Replace button (A-B) is particularly weird.

And so is the Set First button ("1" flipped).
When you announce the new version, you can offer a RTL version (with slightly different icons, not just flipped).
Alternatively you can refer RTL users to the CT plugin.

@pnedev
Copy link
Owner

pnedev commented May 20, 2016

Hello Yaron,

Thank you for summarizing here the known issues. 👍

I don't want to make several releases - it's tedious and is something that's not interesting to me. It is just a routine work and I find it rather boring. Besides, then we would need to have several CP versions in the Plugin Manager which is a mess.

Is it possible to make the button bitmaps universal to both LTR and RTL?

Thanks.

BR

@Yaron10
Copy link
Author

Yaron10 commented May 20, 2016

Hello Pavel,

Only one version in the Plugin Manager.
I'll provide the RTL version if you don't mind (so it's a reminder to myself).
If you do mind, just mention the issue in the Help section and refer the users to CT.

Is it possible to make the button bitmaps universal to both LTR and RTL?

I've done my best. It would require a professional designer.

Thank you.
BR

@Yaron10
Copy link
Author

Yaron10 commented May 20, 2016

Start NPP.
Open 2 new empty files.
Compare.

Result:
The second file is closed.

#17 (comment)
#64 (comment)

@Yaron10
Copy link
Author

Yaron10 commented May 20, 2016

#63 (comment)

@pnedev
Copy link
Owner

pnedev commented May 20, 2016

Hello Yaron,

Thank you for adding that to the known issues list.
I'll fix that later by checking if both files are empty.

BR

@pnedev
Copy link
Owner

pnedev commented May 21, 2016

Hello Yaron,

I've done my best. It would require a professional designer.

You've done a really great job. 👍

Only one version in the Plugin Manager.
I'll provide the RTL version if you don't mind (so it's a reminder to myself).

OK, that's perfect.
How are you going to distribute the RTL version? Just link it in the Plugin forum of N++ community?
Thanks.

BR

@Yaron10
Copy link
Author

Yaron10 commented May 21, 2016

Hello Pavel,

Thank you.

I'll fix that later by checking if both files are empty.

Is my suggestion to programmatically open a new file implementable?

How are you going to distribute the RTL version? Just link it in the Plugin forum of N++ community?

Yes, a link in the forum.

BR

@pnedev
Copy link
Owner

pnedev commented May 22, 2016

Hello Yaron,

Is my suggestion to programmatically open a new file implementable?

Unfortunately no (at least the amount of code is not worth it).
I'll think about what I can do but that's really not that critical issue.

BR

@pnedev
Copy link
Owner

pnedev commented May 22, 2016

Hello Yaron,

I've added the RTL button bitmaps also. Now CP detects if it is in RTL mode and loads the corresponding icons. Could you give latest master a try? Thanks.

I will also need the RTL version of the "Set First" bitmap - it seems you have forgotten to send it to me.
Thank you.

BR

@Yaron10
Copy link
Author

Yaron10 commented May 23, 2016

Hello Pavel,

Is my suggestion to programmatically open a new file implementable?

Unfortunately no (at least the amount of code is not worth it).
I'll think about what I can do but that's really not that critical issue.

The best apps have some Known Issues.
IMO this can be one of CP. :)


I've added the RTL button bitmaps also...

That's great.
I actually thought about it but didn't want to suggest it.
Thank you.

The RTL icons have to be flipped so that when NPP flips them they would be displayed properly. :)
The "Set First" image is the same for LTR and RTL (just flipped); the others are slightly different.
As I uploaded the RTL icons not flipped (for whoever might be interested), I didn't include FirstToCompareRTL.

Are you flipped now? :)

Here are the right RTL icons.

BR

@pnedev
Copy link
Owner

pnedev commented May 23, 2016

Hello Yaron,

The icons in RTL should be flipped horizontally (across the Y axis) right?
I see a difference only in FirstToCompareRTL. All other bitmaps seem the same as the LTR versions.
Are you sure those are needed?
Thanks.

BR

@Yaron10
Copy link
Author

Yaron10 commented May 23, 2016

Hello Pavel,

Yes, the RTL icons should be flipped horizontally.

The images' frame (except FirstToCompare) should represent a "window".
If you just flip them, the frame's gradient and other minor elements would not be displayed as intended.
So there's a difference between the LTR and the RTL icons.

Having said that, it's not that important. The other three icons would be OK flipped by NPP.
It would be fine if you prefer to reduce the resources and only use FirstToCompareRTL.

Thank you.
BR

@Yaron10
Copy link
Author

Yaron10 commented May 23, 2016

It would be fine if you prefer to reduce the resources and only use FirstToCompareRTL.

If you prevent NPP from flipping FirstToCompare or re-flip it, you wouldn't have to use FirstToCompareRTL either.

Thank you.
BR

@pnedev
Copy link
Owner

pnedev commented May 24, 2016

Hello Yaron,

I decided to use only FirstToCompare RTL bitmap.
The others' differences between LTR and RTL variants are hardly noticeable.
The changes are in latest master commit.
Thank you.

BR

@Yaron10
Copy link
Author

Yaron10 commented May 24, 2016

Hello Pavel,

That's a good decision. Most people wouldn't notice the difference.
Thank you.

BR

@Yaron10
Copy link
Author

Yaron10 commented May 24, 2016

Hello Pavel,

I'll close this thread and open Known Issues / Reminders (2).
Thanks.

BR

@Yaron10 Yaron10 closed this as completed May 24, 2016
@pnedev
Copy link
Owner

pnedev commented May 25, 2016

Hello Yaron,

Thanks.

BR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants