Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Known Issues / Reminders (2) #73

Closed
Yaron10 opened this issue May 24, 2016 · 19 comments
Closed

Known Issues / Reminders (2) #73

Yaron10 opened this issue May 24, 2016 · 19 comments

Comments

@Yaron10
Copy link

Yaron10 commented May 24, 2016

Caret position after Clear Compare.
Clear-compare closes original in main view.
Undo list is emptied after Compare.


Start NPP.
Open 2 new empty files.
Compare.

Result:
The second file is closed.


Clear the Recently Closed Files List or have only two files there.
Open two files.
Set First.
Switch to the other file.
Set First.
Close the current file.
Set First.

Result:
The navigation commands/buttons are enabled.

@Yaron10
Copy link
Author

Yaron10 commented Jun 9, 2016

A NPP issue:

Comparing a UTF-8 file to a windows-1255 file - the Encoding-Mismatch warning is not displayed.

@pnedev
Copy link
Owner

pnedev commented Dec 5, 2016

Hello Yaron,

The following issue

Clear the Recently Closed Files List or have only two files there.

Open two files.
Set First.
Switch to the other file.
Set First.
Close the current file.
Set First.

Result:
The navigation commands/buttons are enabled.

seems fixed. Could you try it once again at your side?
Thank you.

BR

@Yaron10
Copy link
Author

Yaron10 commented Dec 6, 2016

Hello Pavel,

Clear the Recently Closed Files List or have only two files there.

The issue still exists on my machine.

This is most definitely not a common use-case.
It may, however, indicate a more serious underlying issue. What do you think?
If you're tired of it, please leave it.

Thank you very much.
BR

@pnedev
Copy link
Owner

pnedev commented Dec 6, 2016

Hello Yaron,

I'll have to try on my Win7 machine.
I cannot reproduce this under Wine.
Thanks.

BR

@Yaron10
Copy link
Author

Yaron10 commented Dec 6, 2016

Hello Pavel,

Thank you. I do appreciate it.
You deserve a lot of compliments for your work and attitude.

BR

@pnedev
Copy link
Owner

pnedev commented Dec 11, 2016

Hello Yaron,

Just to let you know - on my Win7 setup I'm reproducing the issue consistently.
And you are right - it might indicate some underlying problems.
I'll need to investigate more. Thanks.

BR

@Yaron10
Copy link
Author

Yaron10 commented Dec 11, 2016

Hello Pavel,

Thank you. I do appreciate it.

Please take it easy. :)

BR

@pnedev
Copy link
Owner

pnedev commented Dec 11, 2016

Hello Yaron,

One clarification:
To reproduce the issue you simply need to clear the recent list, open a file and then close it.
It makes the problem even worse as it is easily observable.

BR

@Yaron10
Copy link
Author

Yaron10 commented Dec 11, 2016

Hello Pavel,

To reproduce the issue you simply need to clear the recent list, open a file and then close it.

And reopen it. - On my machine.
Anyway, a good catch.

Some comments about "Restore Recently Closed File":
When this feature was first introduced it didn't work properly (e.g. the command's text was often missing).
Don has fixed it since (by "embedding" the text) but now it can't be localized.

I use the MenuIcons plugin.
If you clear the Recent Files list, open a file and close it - most of the menu's icons disappear.
Franco Stellari (MenuIcons Developer) has tried to fix it but to no avail.

I'm not sure these facts are relevant.
Yet, there might be something wrong in the implementation of this dynamically created command which is the cause of our issue.

Thank you very much.
BR

@pnedev
Copy link
Owner

pnedev commented Dec 12, 2016

Hello Yaron,

Interesting. That might have something to do with the issue, you are right, thanks.

BR

@Yaron10
Copy link
Author

Yaron10 commented Dec 12, 2016

Hello Pavel,

Anyway, IMO this is a minor issue which can remain in the Known-Issues list.

Thank you.
BR

@Yaron10
Copy link
Author

Yaron10 commented Feb 21, 2017

Related: buttons state.

Thank you.

@pnedev
Copy link
Owner

pnedev commented Feb 21, 2017

Thanks Yaron.

@pnedev
Copy link
Owner

pnedev commented Feb 28, 2017

Hello,

FYI:

Related: buttons state.

It is fixed with e11d59f.

BR

@Yaron10
Copy link
Author

Yaron10 commented Mar 1, 2017

Hello Pavel,

It works like a charm. 👍
Thank you very much.

BR

@pnedev
Copy link
Owner

pnedev commented Sep 17, 2018

Hello Yaron,

This thread needs to be revised (now that we came to comparing empty files again - #173 :) ).

Thanks to @SinghRajenM, this issue is fixed - #66 .
Because of the new alignment approach this issue is no longer relevant - #57 .

I cannot reproduce this problem:

Clear the Recently Closed Files List or have only two files there.
Open two files.
Set First.
Switch to the other file.
Set First.
Close the current file.
Set First.
Result:
The navigation commands/buttons are enabled.


So the things that remain are:

  1. Clear-compare closes original in main view #48

Open 2 new empty files.
Compare -> Issue - the two files are equal but the compare view is shown without any differences.
Clear compare -> Issue - One file is closed.

The whole second issue (both compare/clear compare) is due to the way Notepad++ opens new file initially and is not related in any way to Compare plugin. I'll try to think of a workaround but I can't promise anything.

  1. Comparing a UTF-8 file to a windows-1255 file - the Encoding-Mismatch warning is not displayed.

I don't know about that but again nothing can be done from CP side to address it.


I'll wait for your feedback on this and then I'll close this thread.
I'll start another one containing only the relevant known issues. Am I missing some other known problem? Do you think 2 and 3 need to be added to the new known problems thread?

Thank you for your time and effort, much appreciated.

BR

@pnedev
Copy link
Owner

pnedev commented Sep 17, 2018

Hello again Yaron,

Regarding point 2 from my previous comment (empty files comparison) - this is fixed as noted here:
#173 .

Thanks.
BR

@Yaron10
Copy link
Author

Yaron10 commented Sep 17, 2018

Hello Pavel,

This thread needs to be revised...

Indeed.

Thanks to @SinghRajenM, this issue is fixed - #66 .
Because of the new alignment approach this issue is no longer relevant - #57 .

👍

I cannot reproduce this problem:
Clear the Recently Closed Files List or have only two files there.
...

I can not reproduce it either.
Great job. :)

Do you think3 need to be added to the new known problems thread?

As you understand.
If you open a new thread for #48, why not adding it too?

Thank you. I do appreciate your work.
BR

@pnedev
Copy link
Owner

pnedev commented Sep 17, 2018

Hello Yaron,

OK, I'll close this thread and later open a new one listing the remaining known problems.
Thank you.

BR

@pnedev pnedev closed this as completed Sep 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants