Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable/Disable Toolbar Buttons #39

Closed
Yaron10 opened this issue Apr 8, 2016 · 11 comments
Closed

Enable/Disable Toolbar Buttons #39

Yaron10 opened this issue Apr 8, 2016 · 11 comments
Labels

Comments

@Yaron10
Copy link

Yaron10 commented Apr 8, 2016

Hello Pavel,

If the Customize Toolbar plugin is not installed, the Compare's toolbar buttons are always enabled.
I think it's important to address this issue (especially now that you enable/disable the commands much more frequently).

If the Customize Toolbar plugin IS installed, there's a problem which is probably related to that plugin.
Still, please have a look.

STR:

Open three files.
Compare.
Activate the third not-compared file.
Activate the compared file at bottom.

Result:

The Compare's toolbar buttons are disabled.

NOTE: If you open a menu and move to another one (e.g. press File and move to Edit), the buttons' state is updated.

Thank you.

BR

@pnedev pnedev added the bug label Apr 9, 2016
@pnedev
Copy link
Owner

pnedev commented Apr 9, 2016

Oh, is that the case?
I haven't noticed that as I'm using the Customize toolbar plugin.
I'll certainly check that, thanks for reporting.

BR

@Yaron10
Copy link
Author

Yaron10 commented Apr 10, 2016

Thank you. I appreciate that.

BR

@Yaron10
Copy link
Author

Yaron10 commented Apr 26, 2016

Hello Pavel,

A related minor issue:
If you "Set first" and then close the selected file, "Clear" should be disabled.

Thank you.

BR

@pnedev
Copy link
Owner

pnedev commented Apr 27, 2016

I'll look into this, thank you.

BR

@pnedev
Copy link
Owner

pnedev commented Apr 27, 2016

Hello Yaron,

The "Set first" issue when the file is closed is fixed. Thanks for catching that.

BR

@Yaron10
Copy link
Author

Yaron10 commented Apr 27, 2016

Hello Pavel,

Thank you very much. I appreciate it.

Best regards.

@pnedev
Copy link
Owner

pnedev commented May 16, 2016

Hello Yaron,

The N++ toolbar CP buttons state issue is fixed, thanks for reporting.

BR

@pnedev pnedev closed this as completed May 16, 2016
@Yaron10
Copy link
Author

Yaron10 commented May 16, 2016

Hello Pavel,

Special thanks. CP is getting better and greater by the day. 👍
Judging by the time-frame, I assume you haven't corresponded with Dave. :)

The navigation buttons state works like a charm.
I still have a problem with "Clear Active Compare" which I've added with CT.
May I ask you to add it to CP code when you have some free time? I'd appreciate that.

BTW, is "Clear All Compares" intentionally always enabled?

Best regards.

@pnedev
Copy link
Owner

pnedev commented May 16, 2016

Hello Yaron,

You are welcome.

BTW, is "Clear All Compares" intentionally always enabled?

Yes, it is. I'll think about disabling it some time in the future.

BR

@Yaron10
Copy link
Author

Yaron10 commented May 16, 2016

Hello Pavel,

Thanks again. I appreciate it.

BR

@Yaron10
Copy link
Author

Yaron10 commented May 18, 2016

Hello Pavel,

Thank you very much. It works like a charm. 👍

BR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants