Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compare margin not removed when closing files without Clear Compare #50

Closed
Yaron10 opened this issue Apr 13, 2016 · 9 comments
Closed
Labels

Comments

@Yaron10
Copy link

Yaron10 commented Apr 13, 2016

Hello Pavel,

STR:

Compare.
Close one of the compared files.

Or:
Compare.
Files match. Close? - Yes.

Result:

Compare margin is not removed.

Thank you.

BR

@pnedev pnedev added the bug label Apr 13, 2016
@pnedev
Copy link
Owner

pnedev commented Apr 13, 2016

Will check that, thanks.

BR

@Yaron10
Copy link
Author

Yaron10 commented Apr 13, 2016

Hello Pavel,

Thank you very much.

BR

@pnedev
Copy link
Owner

pnedev commented Apr 18, 2016

Fixed in master, thanks.

BR

@pnedev pnedev closed this as completed Apr 18, 2016
@Yaron10
Copy link
Author

Yaron10 commented Apr 18, 2016

Hello Pavel,

Files match. Close? - Yes.

Fixed.

Close one of the compared files.

Still a problem in some cases if you don't return to Single-View mode.

I assume you know this issue didn't exist up until a few commits ago.

Thank you.
BR

@pnedev
Copy link
Owner

pnedev commented Apr 18, 2016

Hello Yaron,

Still a problem in some cases if you don't return to Single-View mode.

Can you give me steps how I can reproduce this? Thank you.

BR

@pnedev pnedev reopened this Apr 18, 2016
@pnedev
Copy link
Owner

pnedev commented Apr 18, 2016

Hello Yaron,

I reproduced the issue, I'll look into it, thanks,

BR

@pnedev
Copy link
Owner

pnedev commented Apr 18, 2016

Hello again,

I fixed that in master, however, there is still an issue with the margin when you close a file and another is activated in its view, that is compared. In this case the margin is as if the new file is not compared.
I'll fix that soon too.

BR

@pnedev
Copy link
Owner

pnedev commented Apr 18, 2016

Fixed, thanks.

BR

@pnedev pnedev closed this as completed Apr 18, 2016
@Yaron10
Copy link
Author

Yaron10 commented Apr 20, 2016

Hello Pavel,

Very nice.
Thank you very much.

BR

pnedev added a commit that referenced this issue Oct 28, 2016
fixed the travis build for mingw-w64 on i686 and x64
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants