-
-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Progress Bar #8
Comments
Hello again, I've just seen you've modified the Progress Bar code. Thank you. Best regards. |
Hi Yaron, The features you propose in the link look good I'll see what I can do in the future but this would be 'low priority' task. The progress bar doesn't show the exact progress so it is kind of approximation. It gives me some very rough feedback on the compare process for now. In the future I might remove it but from user perspective I would like to have some info on how the comparing is going and a way to cancel the process if it is overly-slow.
Honestly, I have no idea :) BR |
Hello Pavel, Thanks for considering my suggestion. The most serious problem with the Progress Bar was that the "Cancel" button didn't actually terminate the process. I agree there should be some indication of the comparing process. I guess I'll have to manually follow your commits. Best regards. |
Hi Yaron, As Notepad++ freezes while compare is ongoing I would prefer to have some indication to the user (progress or something) about the operation. That's why I think it shouldn't be an option. The Cancel button works fine but the cancel command is actually sampled by the compare operation on certain points. That's why there might be some delay from clicking 'Cancel' to the actual canceling of the compare operation. This is a limitation of the current implementation. I might change that in the future but it's a lot of rework. I will leave this issue open to point to your status suggestion. BR, |
Like Pavel, I would also prefer progress report, because the comparison blocks NPP. |
Hello Pavel, Yes, a good solid argument. Best regards. |
Hi Yaron, Sure, no problem. BR, |
Accidentally closed the issue, I reopened it again. |
Hello Pavel, Thanks again for your work. I do appreciate it. May I ask you to upload the DLL? Best regards. |
Here it is: BR |
Hello Pavel, Thanks for uploading the DLL. The Cancel button works like a charm and the new design is much nicer. Some minor issues:
BTW, nice addition to the Files Match dialog. Thanks. Best regards. |
Hi Yaron, Thanks for the feedback. BR |
Hello Pavel, Thanks again. I appreciate your time and work. No. 1: The Title Bar is active but mouse-scrolling over either view doesn't work until pressing somewhere in the editor. No. 2 is fixed. 👍 No. 3: Please don't mind that: I meant "Comparing" only in the Progress Bar.
EDIT: In the Files Match dialog:
What do you think? Best regards. |
Hello again Pavel, I've just intercepted UFO's reply to the mouse-scrolling issue:
Could you please have a look at two blocks (search for // Hi Pavel) in the attached Compare.cpp? Thank you. |
Hi Yaron, I did the fixes according your suggestions. BR, |
Hello Pavel, A brilliant work. There's still one issue (sorry): Result: And excuse my perfectionism. :) And wouldn't it be nicer if you add another "\n" before "Close compared files?"? Best regards. |
Hello, I've just seen this commit. Thanks again! I haven't followed all your changes but allow me to ask this:
Are the BR. |
Hi Yaron, The code excerpt
was needed before to refresh the scintilla views but it seems redundant now. I've removed it. About the focus issue - this is a regression I've introduced while fixing the Progress. It is corrected now. Message text suggestion is also implemented. Thanks for testing and reporting, all is fixed in master branch. BR |
Hello Pavel, I've downloaded your fork. :) It seems that comparing large or completely different files is faster with your version. And the DLL size is much smaller which is a good indication too. With your permission two questions regarding the compiling:
Thank you for all the fixes. I appreciate your patience. Regarding
Now that we're implementing I'll do that if you think it's a good idea. BTW, does Best regards. |
Hello Yaron,
Yes, most probably.
I haven't built the Loader project after my code refactoring, thus I haven't noticed that problem. Sorry about that. I'll fix it ASAP.
Perhaps, I don't know for sure. Things are a bit messy at the moment and I don't have a clear idea yet how different parts of code interact. For example "Compare to last save" is not working now perhaps because of the changes we introduced. I'll need some time.
It is the full path. BR, |
Hello Pavel, Thank you for fixing the compilation issues.
I think that's natural even for an experienced and smart developer.
I rarely use this command.
https://notepad-plus-plus.org/community/topic/11307/plug-in-compare-bug/9 I don't know if you've seen this issue. Could you please list the STR to the problem you've found in v15.6.8?
Sure. And thanks also for the "It is the full path" reply. Best regards. |
Hello Yaron, I haven't seen the issue you pointed - it seems it is a known problem. It needs fixing then :)
Yes, that is a good idea, thanks. I'm closing this issue now, feel free to create a new one for the compare status implementation. Thanks. BR |
Indeed. :) Thanks again. |
Hello Pavel,
As of now the Progress Bar doesn't work properly.
Personally I'd remove it and go for this (in the future :) ).
What do you think?
I've removed the relevant code in Compare.cpp, the Progress folder and modified some more files.
BR.
The text was updated successfully, but these errors were encountered: