TypeError: Cannot read property 'all' of undefined

[mhulse]

Hello,

Thanks for this code!

I have this function:

import tipograph from 'tipograph';
makePrettyItem: function(item) {
	return tipograph.Replace.all( ... );
},

I am getting:

		return _tipograph2.default.Replace.all( ... );
		                                   ^

TypeError: Cannot read property 'all' of undefined

I can't seem to figure out how to migrate this old syntax to the new ...

Can you point me in the right direction?

[pnevyk]

Hi @mhulse

thanks for the interest. There should have been a guide, sorry for the inconvenience. So I wrote one. In case that something isn't clear yet, feel free to ask.

I found a bug in custom rules definition and missing docs when I was writing this guide. So thank you for the issue, it helped to improve this library :)

[mhulse]

@pnevyk WOW! Thank you so much for the awesome upgrade guide!!!! I really appreciate your help and the awesome code!

Have a great day!

[mhulse]

Not sure if I should open a new issue or do a PR for this, but I noticed a spelling error in your main README.md:

https://github.com/pnevyk/tipograph/blob/e79850ff6fa3733331d7ea4ed7501a836e09415b/README.md#installation

“In brower”

Let me know if you would like me to do a PR; I totally don’t mind.

Thanks again!

[pnevyk]

@mhulse Sure, I will gladly accept your pull request. All help is very appreciated. If you need any help, just let me know (because I don't have contributing guide either... but I will probably write one).

For this particular PR, just be aware that the content of the README.md file actually lays in .readme.md since readme is generated from it. So you need to update .readme.md file, and build the actual readme by npm run doc, and commit both files. Thanks for you interest and help!