Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

to consider: avoid (0|1)* as asm local label #13

Open
pnkfelix opened this issue Aug 9, 2023 · 1 comment
Open

to consider: avoid (0|1)* as asm local label #13

pnkfelix opened this issue Aug 9, 2023 · 1 comment
Labels
risk-needing-assessment These are todo work items that are potential bugs but need investigation before we can confirm that.

Comments

@pnkfelix
Copy link
Owner

pnkfelix commented Aug 9, 2023

From https://doc.rust-lang.org/rust-by-example/unsafe/asm.html#labels

Moreover, on x86 when using the default Intel syntax, due to an LLVM bug, you shouldn't use labels exclusively made of 0 and 1 digits, e.g. 0, 11 or 101010, as they may end up being interpreted as binary values.
@pnkfelix
Copy link
Owner Author

pnkfelix commented Aug 9, 2023

(its possible this is just outdated advice from RBE, but it still seems worth double-checking...)

@pnkfelix pnkfelix added the risk-needing-assessment These are todo work items that are potential bugs but need investigation before we can confirm that. label Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
risk-needing-assessment These are todo work items that are potential bugs but need investigation before we can confirm that.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pnkfelix