Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

future proofing: use ManuallyDrop rather than mem::forget for callback management #19

Open
pnkfelix opened this issue Aug 24, 2023 · 1 comment

Comments

@pnkfelix
Copy link
Owner

Feedback from zulip is questioning how I'm handling the forgetting of the callback type, namely Elichai Turkel notes:

Doesn't this moves the callback type from the stack and thus invalidating the pointer? IMHO it's easiest to use a ManuallyDrop

std::mem::forget(callback);

@pnkfelix
Copy link
Owner Author

See also discussion on rust-lang/unsafe-code-guidelines#188

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant