Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove aria-labels support #1

Closed
pnmcosta opened this issue Mar 11, 2017 · 0 comments
Closed

Remove aria-labels support #1

pnmcosta opened this issue Mar 11, 2017 · 0 comments
Assignees
@pnmcosta
Labels
enhancement

Comments

@pnmcosta
Copy link
Owner

pnmcosta commented Mar 11, 2017 •
edited

Over-engineered feature, since the links/buttons are configured via html/injection, there's no need to support aria-label's by the plugin. The enhancement will be reducing the plugin's weight.

Configured links/buttons with aria-labels:

<div class="social-container">
    <a href="#" class="facebook" aria-label="Share this page on Facebook" role="button">Share on Facebook</a>
    <button class="twitter" aria-label="Share this page on Twitter">Share on Twitter</button>
</div>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pnmcosta pnmcosta

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pnmcosta