Resolve TS compiler errors #192
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For the "wrapper" components, the error was that the `attachments` object did not accept keys of the `string` type, but the value of the `id_ref` variable was of the `string` type. I resolved these errors by replacing the `[]` index operator with the `Object.getOwnPropertyDescriptor` function. For the error with the top-level `await` statement in the `src/templates/projects_config.ts` file, I bumped the compiler target to `es2017`. Finally, the remaining errors were all variables with the implicit `any` type, which I made explicit. These could be improved by typing the output of the `PouchDB.Database<T>.get` function.
…nto hotfix/tsc_errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #15, resolves #128.
For the "wrapper" components, the error was that the
attachmentsobject did not accept keys of thestringtype, but the value of theid_refvariable was of thestringtype. I resolved these errors by replacing the[]index operator with theObject.getOwnPropertyDescriptorfunction.For the error with the top-level
awaitstatement in thesrc/templates/projects_config.tsfile, I bumped the compiler target toes2017.Finally, the remaining errors were all variables with the implicit
anytype, which I made explicit. These could be improved by typing the output of thePouchDB.Database<T>.getfunction.