Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attachment metadata should only be store in doc.metadata_... #162

Open
charliepnnl opened this issue Aug 23, 2023 · 0 comments
Open

Attachment metadata should only be store in doc.metadata_... #162

charliepnnl opened this issue Aug 23, 2023 · 0 comments

Comments

@charliepnnl
Copy link
Contributor

Currently attachment metadata is being stored in two places:

  • In `doc.metadata_.attachments[*]
  • In the store state variable attachments[*].metadata

This is potentially confusing and error prone.
I would like to eliminate attachments[*].metadata.
This has several ramifications:

  • The form of the attachments store state variable can be simplified to attachments = {[id]: blog, ...}.
    • Any code that uses the attachments variable will need to be updated accordingly.
  • Any component wrapper that uses attachment metadata will need to pull metadata from StoreContext.Consumer.
@charliepnnl charliepnnl added this to the Offline Release milestone Aug 23, 2023
@charliepnnl charliepnnl changed the title Attachment metadata should only be store in metadata_... Attachment metadata should only be store in doc.metadata_... Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant