Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort out postgresql pool mess #26

Open
pnorman opened this issue Feb 2, 2024 · 1 comment
Open

Sort out postgresql pool mess #26

pnorman opened this issue Feb 2, 2024 · 1 comment

Comments

@pnorman
Copy link
Owner

pnorman commented Feb 2, 2024

Currently Storage takes a pool and the dev/live servers give it a connection pool of size 1. This is a bit silly, since connections could be handed in instead. There's a few options, which should be considered after the parallelism work is done

  • continue as-is because it might turn out Storage needs to take a pool for parallelism reasons later on
  • change Storage to take a connection

I don't see an obvious way to have variables that are global between multiple serving processes, so having a pool of a size > 1 won't work with uvicorn

@pnorman
Copy link
Owner Author

pnorman commented Mar 6, 2024

Something to consider is how to handle terminated connections and check that any options will do that

@pnorman pnorman mentioned this issue Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant