-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
spo app add does not return App Id only anymore #11
Comments
Thanks for reporting the issue. Let's resolve the issue with CLI first and based on that handle this issue, ok? |
We'll fix it in the CLI |
Hi, was this fixed or will it be fixed in CLI? I currently added a local copy and added |
@milanholemans so I guess there are 2 ways to fix this Github Action, to me it looks like it's currently broken? https://github.com/pnp/action-cli-deploy/blob/master/src/main.ts should be updated to //row 27
appId = await executeCLIMicrosoft365Command(`spo app add -p ${appFilePath} --scope sitecollection --appCatalogUrl ${siteCollectionUrl} ${overwrite} --output text`, true);
//row 31
appId = await executeCLIMicrosoft365Command(`spo app add -p ${appFilePath} ${overwrite} --output text`, true); alternatively //row 28
await executeCLIMicrosoft365Command(`spo app deploy --id ${JSON.parse(appId).UniqueId} --scope sitecollection --appCatalogUrl ${siteCollectionUrl} ${skipFeatureDeployment}`);
//row 32
await executeCLIMicrosoft365Command(`spo app deploy --id ${JSON.parse(appId).UniqueId} ${skipFeatureDeployment}`); |
Hi @FredrikEkstroem you can completely ignore my last comment. I thought I was replying to an issue in the regular CLI repo (my bad). You are right, this seems like a bug, let's create an issue for this (#18). |
This is a related issue with pnp/cli-microsoft365#2080
Maybe include the solution that consist to replace
UniqueId
string from the returned result of thespo app add
command.The text was updated successfully, but these errors were encountered: