[Microsoft Graph v1.0]: aad siteclassification set

[garrytrinder]

The aad siteclassification set command currently uses the beta/settings endpoint in its implementation, this should be updated to use the v1.0/groupSettings endpoint.

cli-microsoft365/src/m365/aad/commands/siteclassification/siteclassification-set.ts

Lines 42 to 48 in 1bae1ad

	const requestOptions: any = {
	url: `${this.resource}/beta/settings`,
	headers: {
	accept: 'application/json;odata.metadata=none'
	},
	responseType: 'json'
	};

Note: The /beta version of this API is only applies to groups. The /v1.0 version of this API has been renamed to Get groupSetting.

beta docs: https://docs.microsoft.com/en-us/graph/api/directorysetting-get?view=graph-rest-beta&tabs=http
v1.0 docs: https://docs.microsoft.com/en-us/graph/api/resources/groupsetting?view=graph-rest-1.0&tabs=http

cli-microsoft365/src/m365/aad/commands/siteclassification/siteclassification-set.ts

Lines 131 to 139 in 1bae1ad

	const requestOptions: any = {
	url: `${this.resource}/beta/settings/${unifiedGroupSetting[0].id}`,
	headers: {
	accept: 'application/json;odata.metadata=none',
	'content-type': 'application/json'
	},
	responseType: 'json',
	data: updatedDirSettings
	};

Note: The /beta version of this API only applies to groups. The /v1.0 version of this API has been renamed to Update groupSettings.

beta docs: https://docs.microsoft.com/en-us/graph/api/directorysetting-update?view=graph-rest-beta&tabs=http
v1.0 docs: https://docs.microsoft.com/en-us/graph/api/groupsetting-update?view=graph-rest-1.0&tabs=http

[Atharva321]

Hii, I am interested to work on this issue.

[Atharva321]

will only changing endpoint on line no. 43 and 132 fix the issue?

[garrytrinder]

Thank you for your help @Atharva321 👍

We should also remove the attention remark in the corresponding documentation page and update the requests in the corresponding tests to reflect the change from using the beta endpoint to the v1.0 endpoint.

[Atharva321]

Hii, Done the PR . Plz any other changes need to be done or its fine?

[waldekmastykarz]

Thank you! We'll review the PR shortly