New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New command: planner plan set
#3346
Comments
seems well prepared. Good job 👍 |
Thanks @Adam-it, let's open it up. |
Can I work on this? |
Hi guys, Of course you can work in it @nanddeepn. I do have a question on the specs though. I personally find the It's slightly more typing, but then we could use autocomplete to let users be able to quickly type the category keys. |
And maybe, just thinking out loud here: Wouldn't it be better to name it For example: m365 planner plan set --id someid --category1 ToDo --category2 Done m365 planner plan set --id someid --category1 ToDo --category2 Done --sharedWith adelev@blimped.nl,alexw@blimped.nl |
That's definitely a good idea @martinlingstuyl. We don't have so many variables to modify within the plan category model, so we can indeed better apply this in a |
That would be awesome! And then let's see if others have additional good ideas about this. |
planner plan category set
planner plan set
Hey @martinlingstuyl, the specs have been updated. Could you take a look at the option |
Good question, We have something a bit like it in the But maybe in this case we should just use:
@waldekmastykarz or @garrytrinder have an opinion on this? |
Since we're talking about 25 options, I'd suggest that we indeed use the ability to pass unknown options to the command, but then in validation use a regex to validate that the specified options are correct and that no truly unknown options (like --foo) are used. Does this make sense? |
Ok, so @Jwaegebaert, let's add it to the remarks, like with spo field set. Since we don't declare the unknowns a options there as well, let's not do it here either. I'll remove the category option and open it up. |
Still interested to work on this @nanddeepn? |
Hi @martinlingstuyl Just one question: |
Seems duplicate issue of #2531 |
I think the issue #2531 had an PR which was closed to being inactive for very long time. |
Indeed, I'd say: let us merge the specs and close the other issue. |
The specs have been updated to include the suggestions from issue #2531 |
Hey @nanddeepn, are you still interested to work on this new command? |
Hi @Jwaegebaert |
Super, all yours @nanddeepn. Thanks for all your hard work! |
Usage
planner plan set
Description
Updates a Microsoft Planner plan
Options
-i, --id [id]
id
ortitle
but not both.-t, --title [title]
id
ortitle
but not both.--ownerGroupId [ownerGroupId]
ownerGroupId
orownerGroupName
when usingtitle
.--ownerGroupName [ownerGroupName]
ownerGroupId
orownerGroupName
when usingtitle
.--newTitle [newTitle]
--shareWithUserIds [shareWithUserIds]
shareWithUserIds
orshareWithUserNames
but not both.--shareWithUserNames [shareWithUserNames]
shareWithUserIds
orshareWithUserNames
but not both.Unknown Options
--category1 [category1]
--category4
,--category12
In the docs section for this command, we'll reference the
category
options as unknown options in the remarks section. We'll need to validate the unknown options so that only category1-25 can actually be used.Examples
Updates a Microsoft Planner plan title to New Title for the plan with id gndWOTSK60GfPQfiDDj43JgACDCb.
Share a Microsoft Planner plan with title Plan Title that is owned by the group My Group, with the users user1@contoso.com and user2@contoso.com
Updates a Microsoft Planner plan category label with the key 21 to ToDo also the category label with the key 25 to Urgent. This for the plan with id gndWOTSK60GfPQfiDDj43JgACDCb.
Additional Info
Graph docs:
The text was updated successfully, but these errors were encountered: