Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

New command: m365 context remove 馃Ш #4043

Closed
Adam-it opened this issue Nov 11, 2022 · 5 comments
Closed

New command: m365 context remove 馃Ш #4043

Adam-it opened this issue Nov 11, 2022 · 5 comments

Comments

@Adam-it
Copy link
Contributor

Adam-it commented Nov 11, 2022

Usage

m365 context remove [options]

Description

Removes the context file

Options

Option Description
--confirm Don't prompt for confirming removing the file

Examples

Removes the context file. Prompts for confirmation

m365 context remove

Removes the context file. without prompting

m365 context remove --confirm

Additional Info

Initially discussed in issue #3896

The aim of this command is to remove the file .m365rc.json (if present only with context property). When the m365rc,json has other data in it running this command should only remove the context property

@Adam-it Adam-it added new feature needs peer review Needs second pair of eyes to review the spec or PR labels Nov 11, 2022
@Adam-it
Copy link
Contributor Author

Adam-it commented Nov 11, 2022

@pnp/cli-for-microsoft-365-maintainers any comments before we open this up 馃?

@Adam-it Adam-it added on hold and removed needs peer review Needs second pair of eyes to review the spec or PR labels Nov 11, 2022
@Adam-it
Copy link
Contributor Author

Adam-it commented Nov 11, 2022

actually I will put it on hold until we will developed the mechanism to use the context in any executed command
#4047

@Adam-it Adam-it mentioned this issue Nov 11, 2022
6 tasks
@waldekmastykarz
Copy link
Member

Spec seems solid. I don't think we need to wait with implementing this command until we support using context.

@nicodecleyre
Copy link
Contributor

Hi @Adam-it, can I work on this?

@Adam-it
Copy link
Contributor Author

Adam-it commented Nov 17, 2022

Hi @Adam-it, can I work on this?

All yours.
@nicodecleyre thanks for all your awesome work. Please also consider your health and don't overdo it 馃憤. We are all in this together and there is no rush if some feature will not make it for the V6 release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants