We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
webUrl
Currently, we have multiple commands using the method getSpoSiteId. These methods all have the same functionallty. The code is the following:
getSpoSiteId
private async getSpoSiteId(args: CommandArgs): Promise<string> { const url = new URL(args.options.webUrl!); const requestOptions: CliRequestOptions= { url: `${this.resource}/v1.0/sites/${url.hostname}:${url.pathname}`, headers: { accept: 'application/json;odata.metadata=none' }, responseType: 'json' }; const site = await request.get<{ id: string }>(requestOptions) return site.id! }
As this code is reused multiple times, it would be handy if this code is added to a util such as aadGroup.
aadGroup
This method is currently used in the following commands:
The text was updated successfully, but these errors were encountered:
Great suggestion @MathijsVerbeeck! It's always a good idea to move duplicate code to a single location. Are you interested to work on this one?
Sorry, something went wrong.
Sure, go ahead and assign me.
Awesome, all yours!
FYI: I'm currently waiting for PR #4312 to be completed so that I can immediately add this to all the commands.
onenote page list
db7f04a
MathijsVerbeeck
Successfully merging a pull request may close this issue.
Currently, we have multiple commands using the method
getSpoSiteId
. These methods all have the same functionallty. The code is the following:As this code is reused multiple times, it would be handy if this code is added to a util such as
aadGroup
.This method is currently used in the following commands:
The text was updated successfully, but these errors were encountered: