Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New command: purview threatassessment get #4427

Closed
Tracked by #4351
nicodecleyre opened this issue Jan 28, 2023 · 12 comments
Closed
Tracked by #4351

New command: purview threatassessment get #4427

nicodecleyre opened this issue Jan 28, 2023 · 12 comments

Comments

@nicodecleyre
Copy link
Contributor

nicodecleyre commented Jan 28, 2023

Usage

m365 purview threatassessment get [options]

Description

Get a threat assessment

Options

Option Description
-i, --id <id> The Id of the threat assessment

Examples

Get a threat assessment by id

m365 purview threatassessment get --id 6f4fb2db-ecf4-4279-94ba-23d059bf157e

Default properties

No response

Additional Info

API request: https://learn.microsoft.com/en-us/graph/api/threatassessmentrequest-get?view=graph-rest-1.0&tabs=http

Needed permissions

  • ThreatAssessment.Read.All
@milanholemans milanholemans added needs peer review Needs second pair of eyes to review the spec or PR feature request labels Jan 28, 2023
@martinlingstuyl
Copy link
Contributor

What would be the idea behind retrieving by id and type, @nicodecleyre? Does it add value?

@nicodecleyre
Copy link
Contributor Author

What would be the idea behind retrieving by id and type, @nicodecleyre? Does it add value?

Good point @martinlingstuyl ! Since Id is unique, I'll remove the type option

@martinlingstuyl
Copy link
Contributor

Another thing: could you mention the necessary permissions: ThreatAssessment.Read.All. They will need to be added to our AAD app

@nicodecleyre
Copy link
Contributor Author

Another thing: could you mention the necessary permissions: ThreatAssessment.Read.All. They will need to be added to our AAD app

good remark! updated the specs!

@MathijsVerbeeck
Copy link
Contributor

Minor remark - currently you are specifying ID as being optional, however it should be required I believe.

@martinlingstuyl
Copy link
Contributor

It looks required to me @MathijsVerbeeck...

@MathijsVerbeeck
Copy link
Contributor

It looks required to me @MathijsVerbeeck...

image
It does indeed now ;-)

@martinlingstuyl martinlingstuyl added help wanted good first issue and removed needs peer review Needs second pair of eyes to review the spec or PR labels Feb 10, 2023
@martinlingstuyl
Copy link
Contributor

Should we add a flag so that people can expand the response object with the results of the assessment?

Using $expand=results in the query to retrieve the threat assessment result.

@nicodecleyre
Copy link
Contributor Author

Should we add a flag so that people can expand the response object with the results of the assessment?

Using $expand=results in the query to retrieve the threat assessment result.

Sounds good! expandResult as name for the option?

@martinlingstuyl
Copy link
Contributor

something like includeResult. Other opinions, @pnp/cli-for-microsoft-365-maintainers

@MathijsVerbeeck
Copy link
Contributor

Pick me!

@milanholemans
Copy link
Contributor

All yours!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants