Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement, get planner by rosterId #4465

Closed
nicodecleyre opened this issue Feb 4, 2023 · 9 comments
Closed

Enhancement, get planner by rosterId #4465

nicodecleyre opened this issue Feb 4, 2023 · 9 comments
Assignees
Milestone

Comments

@nicodecleyre
Copy link
Contributor

Right now the command planner plan get retrieves the plan when you provide the rosterId next to id or title. Let's enhance the command so you can retrieve the plan just by providing the rosterId option.

The options ownerGroupId and ownerGroupName optionset should only run when title is provided.

Example:

m365 planner plan get --rosterId "RuY-PSpdw02drevnYDTCJpgAEfoI"

instead of

m365 planner plan get --title PlannerTitle --rosterId "RuY-PSpdw02drevnYDTCJpgAEfoI"
@MathijsVerbeeck
Copy link
Contributor

MathijsVerbeeck commented Feb 4, 2023

This should already be implemented if I'm not mistaken by PR #4432 (issue #4401)

@nicodecleyre
Copy link
Contributor Author

nicodecleyre commented Feb 4, 2023

This should already be implemented if I'm not mistaken by PR #4432 (issue #4401)

let me be more specific, right now it is implemented, but you have to provide (title or id) & rosterId, we should be able to provide rosterId single like discussed here

@milanholemans
Copy link
Contributor

Let's make the commands consistent indeed, would you like to fix this @nicodecleyre?

@martinlingstuyl
Copy link
Contributor

@nicodecleyre, how would you be able to get a plan by rosterId if there are more plans in said roster?

@MathijsVerbeeck
Copy link
Contributor

@nicodecleyre, how would you be able to get a plan by rosterId if there are more plans in said roster?

There is only the ability to have one plan per roster and not multiple.

@nicodecleyre
Copy link
Contributor Author

Let's make the commands consistent indeed, would you like to fix this @nicodecleyre?

Sure

@martinlingstuyl
Copy link
Contributor

There is only the ability to have one plan per roster and not multiple.

Are you sure @MathijsVerbeeck, it seems odd that the graph endpoint returns an array for it:

https://learn.microsoft.com/en-us/graph/api/plannerroster-list-plans?view=graph-rest-beta&tabs=http

@martinlingstuyl
Copy link
Contributor

martinlingstuyl commented Feb 5, 2023

I find it odd, but somewhere else I read 'A plannerRoster can contain one plan.', so you must be correct

https://learn.microsoft.com/en-us/graph/api/resources/plannerroster?view=graph-rest-beta

@milanholemans
Copy link
Contributor

Graph endpoint indeed returns an array, but if you try to add multiple plans to the same roster, you are getting an error. Also in the documentation they always refer to a single plan, never multiple plans. E.g. "when you remove the roster, the plan and its tasks are also removed".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants