Bug report: m365 login doesn't accept short option for secret

[nicodecleyre]

Priority

(Low) Something is a little off

Description

When using the short option for secret, you get an error message 'Error: 'GUID,secret' is not a valid authentication type'. This is because in the code there is no short option defined for the secret option:

cli-microsoft365/src/m365/commands/login.ts

Lines 84 to 86 in f473be5

	{
	option: '--secret [secret]'
	},

While in the docs it states that a short option is possible

cli-microsoft365/docs/docs/cmd/login.md

Lines 31 to 32 in f473be5

	`-s, --secret [secret]`
	: Client Secret of the Azure AD application to use for authentication. Required when `authType` is set to `secret`.

Either we add the short option for secret in the code or we remove the short option in the docs

Steps to reproduce

Execute m365 login --appId [your app id] -s [your secret] --tenant [your tenant id] --authType secret

Expected results

that the command executes with the short options for secret

Actual results

'Error: 'GUID,secret' is not a valid authentication type'.

Diagnostics

No response

CLI for Microsoft 365 version

6.8.0

nodejs version

18.12.1

Operating system (environment)

Windows

Shell

PowerShell

cli doctor

No response

Additional Info

No response

[milanholemans]

Great find @nicodecleyre!
We have 2 choices:

1. Remove short from the docs
2. Add short to the code

My gut feeling says we should go for option 2.

[nicodecleyre]

My guts feeling says the same, but then my next remark is that the other options you use in conjunction with the secret option don't have a short. More specific appId & tenant.

example:
m365 login --appId [your app id] -s [your secret] --tenant [your tenant id] --t secret

[milanholemans]

In case you authenticate with a certificate, you'll encounter the same because certificateFile has a short -c.

[milanholemans]

Do you want to work on this one?

[nicodecleyre]

Do you want to work on this one?

Fine by me 😁. So adding the short to the code is the final verdict?

[milanholemans]

Let's do that yes 😃