Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Allow to update the clientSideComponentId of a listview commandset #4963

Closed
Tracked by #4219
martinlingstuyl opened this issue May 31, 2023 · 8 comments
Closed
Tracked by #4219
Assignees
Milestone

Comments

@martinlingstuyl
Copy link
Contributor

martinlingstuyl commented May 31, 2023

Allow to update the clientSideComponentId of a ListView Command Set on a site.

Options

Option Description
--newClientSideComponentId [newClientSideComponentId] The new Client Side Component Id (GUID) of the ListView Command Set.
@martinlingstuyl
Copy link
Contributor Author

Hi @pnp/cli-for-microsoft-365-maintainers, what do you think about this? If you currently update commandsets you can reference them by id, title or clientSideComponentId. So if you want to update the title, we use the newTitle option. There's currently no way to update the clientSideComponentId though. That's the reason I added this.

@milanholemans
Copy link
Contributor

I can't quite follow

There's currently no way to update the clientSideComponentId though. That's the reason I added this.

So why are you adding newClientSideComponentId then?

@martinlingstuyl
Copy link
Contributor Author

There's no way to do it using the CLI, I mean... the API does support it.

@milanholemans
Copy link
Contributor

milanholemans commented Jun 1, 2023

Aha, in that case, LGTM!

@Adam-it
Copy link
Contributor

Adam-it commented Jun 4, 2023

Looks good for me too 👍. Let's open it up

@Adam-it Adam-it added help wanted and removed needs peer review Needs second pair of eyes to review the spec or PR labels Jun 4, 2023
@nicodecleyre
Copy link
Contributor

Can I work on this one? This is an update for both spo commandset set and spo tenant commandset set?

@martinlingstuyl
Copy link
Contributor Author

Hi @nicodecleyre, this is the spo command, the spo tenant commmand has a different issue.

I'll assign you 🤙

@martinlingstuyl
Copy link
Contributor Author

The tenant version is a breaking change, as it includes multiple changes:

#4961

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants