Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New sample script: Enabling/disabling comments on SharePoint lists at tenant level #4979

Closed
ganesh-sanap opened this issue Jun 4, 2023 · 8 comments
Assignees
Labels
Milestone

Comments

@ganesh-sanap
Copy link
Contributor

Docs
Author Ganesh Sanap (@ganesh-sanap)
Original Post https://ganeshsanapblogs.wordpress.com/2021/01/09/how-to-enable-disable-the-commenting-in-sharepoint-online-microsoft-lists/
Description This script can be used to enable/disable commenting on all SharePoint online lists / Microsoft Lists in your SharePoint tenant, related to #4777
Keywords SharePoint Online Microsoft Lists List Commenting

I would like to work on this if you are OK with this sample script.

@Adam-it
Copy link
Contributor

Adam-it commented Jun 4, 2023

Seems like a quite simple case but I don't see why we should not add it. Thanks for the suggestion 👍. You rock 🤩.
All yours 🚀

@milanholemans
Copy link
Contributor

I'm grateful to @ganesh-sanap to come up with sample scripts. But to be honest to me this doesn't really look like a sample script. It's literally 1 command execution. In my opinion, it would fit better as an example on the spo tenant settings set docs. If we allow this to pass, that would mean that people can create a sample script for every command.

Sorry, but I don't think this is a good idea.

@Adam-it
Copy link
Contributor

Adam-it commented Jun 5, 2023

You have a point there. I agree. For me, it also seemed a bit too simple but I didn't see any harm in adding it 🤔.
Why don't we use this issue (energy) to improve the spo tenant settings set docs with a new example instead of adding this as a sample? @ganesh-sanap would that work for you?
@milanholemans what do you think?

@milanholemans
Copy link
Contributor

You have a point there. I agree. For me, it also seemed a bit too simple but I didn't see any harm in adding it 🤔. Why don't we use this issue (energy) to improve the spo tenant settings set docs with a new example instead of adding this as a sample? @ganesh-sanap would that work for you? @milanholemans what do you think?

Sure, that would be fine! 😊

@ganesh-sanap
Copy link
Contributor Author

You have a point there. I agree. For me, it also seemed a bit too simple but I didn't see any harm in adding it 🤔. Why don't we use this issue (energy) to improve the spo tenant settings set docs with a new example instead of adding this as a sample? @ganesh-sanap would that work for you? @milanholemans what do you think?

@Adam-it I am happy to contribute either way, sample script or documentation example.

@Adam-it
Copy link
Contributor

Adam-it commented Jun 6, 2023

Awesome, let's improve the docs then 👍

@ganesh-sanap
Copy link
Contributor Author

I'm grateful to @ganesh-sanap to come up with sample scripts. But to be honest to me this doesn't really look like a sample script. It's literally 1 command execution. In my opinion, it would fit better as an example on the spo tenant settings set docs. If we allow this to pass, that would mean that people can create a sample script for every command.

Sorry, but I don't think this is a good idea.

@milanholemans I thought the same that this is a very simple script/use case before adding this issue here. So, I did some research before adding it and found that there are few simple script samples similar to it.

For example:

  1. Add App Catalog to SharePoint site
  2. Hide SharePoint list from Site Contents
  3. Authenticate with and call the Microsoft Graph

So, I thought of adding this suggestion here and collecting the thoughts of maintainers.

@milanholemans
Copy link
Contributor

There are indeed some debatable script samples on our docs. The Graph sample script used to be useful because it wasn't trivial to perform Graph queries using CLI. Right now you can just use m365 request for that. So, yeah we constantly have to revise everything, but unfortunately, that's quite some work. A few weeks ago we already got rid of a sample script because it got replaced by a command. (#4752)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants