Enhancement: aad m365group add visibilty option

[milanholemans]

Currently, we can create private and public Microsoft 365 groups by specifying or omitting the --isPrivate flag.
However, in fact, you can create 3 types of Microsoft 365 groups, reading the docs:

Property	Type	Description
visibility	String	Specifies the group join policy and group content visibility for groups. Possible values are: Private, Public, or HiddenMembership. HiddenMembership can be set only for Microsoft 365 groups, when the groups are created. It can't be updated later. Other values of visibility can be updated after group creation. If visibility value is not specified during group creation on Microsoft Graph, a security group is created as Private by default and Microsoft 365 group is Public. Groups assignable to roles are always Private. To learn more, see group visibility options.

Therefore I suggest that we remove --isPrivate and replace it with:

Option	Description
--visibility [visibility]	Specifies the group join policy and group content visibility for groups. Possible values are: Private, Public, or HiddenMembership. Defaults to Public.

• Let's also add a remark that warns the user that you cannot change the group type when you choose HiddenMembership.
• Let's add a remark that explains all group visibilities
• Let's recheck all sample scripts for breaking changes.

[milanholemans]

@pnp/cli-for-microsoft-365-maintainers any remarks?

[Jwaegebaert]

Good suggestion! Let's be sure that we clearly explain the effects of the type HiddenMembership

[SmitaNachan]

Can I work on it?

[martinlingstuyl]

Hi @SmitaNachan, just wanted to give you and ask for a timeline on this: v7 is around the corner, we'd like to start a code freeze in about a week to avoid changing things to short before the release.

How are you doing on this PR and the other breaking change? Do let us know!

[SmitaNachan]

Thanks @martinlingstuyl, Raised PR #5497 😊

[martinlingstuyl]

Fantastic!!