Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider renaming 'externalconnection' commands #5531

Closed
waldekmastykarz opened this issue Sep 27, 2023 · 9 comments
Closed

Consider renaming 'externalconnection' commands #5531

waldekmastykarz opened this issue Sep 27, 2023 · 9 comments
Assignees
Labels
enhancement hacktoberfest Issue perfect for hacktoberfest
Milestone

Comments

@waldekmastykarz
Copy link
Member

We should consider renaming search externalconnection commands to external connection.

Originally, when external connections have been introduced, their primary use was around bringing external content to Microsoft Search. As the functionality evolved, external content ingested through Graph connector appears in Microsoft Search, ContextIQ and the Microsoft 365 app, and in the near future also in Microsoft 365 Copilot.

I'd like to suggest that we rename the commands to external connection. It will:

  1. remove the search association and avoid confusion for folks who'll be looking for it in the context of copilot
  2. allow us to accommodate external item in the external namespace, rather than search externalitem

Looking forward to hearing what you think @pnp/cli-for-microsoft-365-maintainers

@milanholemans
Copy link
Contributor

Looks good to me!

@waldekmastykarz
Copy link
Member Author

Thanks, let's wait for a couple more votes/opinions, to ensure we're not missing anything

@Jwaegebaert
Copy link
Contributor

Renaming to external connection sounds like a logical step, aligning with the expanded functionality. It avoids confusion and fits well in the external namespace. A positive change overall. Looks good to me!

@martinlingstuyl
Copy link
Contributor

If the scope has broadened, so be it! I'm on board with this!

@nanddeepn
Copy link
Contributor

Can I work on it?

@garrytrinder
Copy link
Member

All yours @nanddeepn 👍

@martinlingstuyl
Copy link
Contributor

@waldekmastykarz, @nanddeepn, its not in the issue specs, but this seems to me a breaking change, for which we would need to add an alias after renaming. Correct?

@nanddeepn
Copy link
Contributor

Hi @martinlingstuyl
Yes, good catch.

@waldekmastykarz
Copy link
Member Author

@martinlingstuyl correct, that was implicit, but we should make it explicit to avoid confusion and simplify implementing the change and reviewing the PR. Good catch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement hacktoberfest Issue perfect for hacktoberfest
Projects
None yet
6 participants