New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider renaming 'externalconnection' commands #5531
Comments
Looks good to me! |
Thanks, let's wait for a couple more votes/opinions, to ensure we're not missing anything |
Renaming to |
If the scope has broadened, so be it! I'm on board with this! |
Can I work on it? |
All yours @nanddeepn 👍 |
@waldekmastykarz, @nanddeepn, its not in the issue specs, but this seems to me a breaking change, for which we would need to add an alias after renaming. Correct? |
Hi @martinlingstuyl |
@martinlingstuyl correct, that was implicit, but we should make it explicit to avoid confusion and simplify implementing the change and reviewing the PR. Good catch! |
We should consider renaming
search externalconnection
commands toexternal connection
.Originally, when external connections have been introduced, their primary use was around bringing external content to Microsoft Search. As the functionality evolved, external content ingested through Graph connector appears in Microsoft Search, ContextIQ and the Microsoft 365 app, and in the near future also in Microsoft 365 Copilot.
I'd like to suggest that we rename the commands to
external connection
. It will:external item
in theexternal
namespace, rather thansearch externalitem
Looking forward to hearing what you think @pnp/cli-for-microsoft-365-maintainers
The text was updated successfully, but these errors were encountered: